Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOGX V4 #728

Merged
merged 13 commits into from
Oct 24, 2023
Merged

IOGX V4 #728

merged 13 commits into from
Oct 24, 2023

Conversation

zeme-wana
Copy link
Contributor

@zeme-wana zeme-wana commented Oct 13, 2023

Updates the nix code to iogx v4 ; notable changes:

  • formatters.nix included in shell.nix
  • more explicit outputs in outputs.nix
  • no more inputs/inputs', just inputs
  • l argument renamed to lib

This also reduces the shell size and should fix the occasional out-of-disk errors when running the integration tests

@zeme-wana zeme-wana force-pushed the iogx-v4r branch 2 times, most recently from eb38b89 to 5a4ed46 Compare October 16, 2023 14:27
@zeme-wana zeme-wana marked this pull request as ready for review October 16, 2023 14:29
@zeme-wana zeme-wana added the No Changelog Required Turns of the check-changelog check label Oct 17, 2023
Copy link
Collaborator

@hrajchert hrajchert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested entering nix shell, building and running tests 👍🏻

@hrajchert hrajchert merged commit 31033fa into main Oct 24, 2023
5 checks passed
@hrajchert hrajchert deleted the iogx-v4r branch October 24, 2023 14:30
renebarbosafl pushed a commit that referenced this pull request Nov 2, 2023
Updates the nix code to iogx v4 ; notable changes:
- `formatters.nix` included in `shell.nix`
- more explicit outputs in `outputs.nix`
- no more `inputs/inputs'`, just `inputs`
- `l` argument renamed to `lib`

This also reduces the shell size and should fix the occasional
out-of-disk errors when running the integration tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Changelog Required Turns of the check-changelog check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants