Skip to content

Conversation

@DominikGuzei
Copy link
Member

Description

Jira ticket link: https://input-output.atlassian.net/browse/LW-13999

Implements bidirectional language synchronization between Lace v1 and the LMP bundle (v2) via the globalThis.bundleV1 API pattern.

Changes

  • Extended BundleAppApi type with language$ observable and setLanguage() method
  • Added v1Language$ and setV1Language to LmpBundleDependencies
  • Implemented two side effects: syncV1LanguageToV2 (v1→v2) and syncV2LanguageToV1 (v2→v1)
  • Added unit tests covering language sync, deduplication, and skip-first-emission behavior

@DominikGuzei DominikGuzei requested review from a team as code owners December 5, 2025 18:15
@lace-bot
Copy link
Collaborator

lace-bot commented Dec 5, 2025

Allure Report

allure-report-publisher generated test report!

processReports: ✅ test report for eb0514ab

passed failed skipped flaky total result
Total 35 0 5 0 40

@DominikGuzei DominikGuzei force-pushed the feat/lw-13999-keep-language-selection-in-sync-between-v1-and-lmp branch from 6393f0b to 4c43000 Compare December 5, 2025 23:12
Copy link
Contributor

@pczeglik-iohk pczeglik-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @DominikGuzei

Copy link
Contributor

@greatertomi greatertomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DominikGuzei DominikGuzei force-pushed the feat/lw-13999-keep-language-selection-in-sync-between-v1-and-lmp branch from 4c43000 to eb0514a Compare December 8, 2025 10:43
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2025

@DominikGuzei DominikGuzei merged commit a788d37 into main Dec 8, 2025
27 checks passed
@DominikGuzei DominikGuzei deleted the feat/lw-13999-keep-language-selection-in-sync-between-v1-and-lmp branch December 8, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants