Skip to content

feat: improve icon for midnight wallet [LW-13692] #2095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
greatertomi merged 1 commit into from
Dec 9, 2025
Merged

feat: improve icon for midnight wallet [LW-13692] #2095

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...ension-wallet/src/components/MainMenu/DropdownMenuOverlay/DropdownMenuOverlay.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,3 +227,7 @@
.walletOptionBitcoin > div {
background: var(--data-orange);
}

.walletOptionMidnight > div {
background: var(--data-bright-blue);
}
9 changes: 6 additions & 3 deletions ...wser-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/components/UserInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ export const UserInfo = ({
);

const renderLmpWallet = useCallback(
({ walletIcon, walletId, walletName }: LmpBundleWallet, isLast: boolean) => (
({ walletId, walletName }: LmpBundleWallet, isLast: boolean) => (
<div key={walletId}>
<ProfileDropdown.WalletOption
style={{ textAlign: 'left' }}
Expand All @@ -206,8 +206,11 @@ export const UserInfo = ({
onClick={switchToLMP}
type={'hot'}
profile={{
fallbackText: walletName,
imageSrc: walletIcon
customProfileComponent: (
<span className={styles.walletOptionMidnight}>
<ProfileDropdown.WalletIcon type="hot" testId={'wallet-option-icon'} />
</span>
)
}}
/>
{isLast ? undefined : <Separator />}
Expand Down
5 changes: 3 additions & 2 deletions v1/apps/browser-extension-wallet/src/lib/scripts/background/services/lmpService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,12 @@ const api: BundleAppApi = {
map((wallets) =>
wallets.map(
(wallet): LmpBundleWallet => ({
// TODO: icon should be different based on wallet type (same as in v1 dropdown menu)
walletIcon: isBitcoinWallet(wallet) ? bitcoinLogo : cardanoLogo,
walletId: wallet.walletId,
walletName: wallet.metadata.name,
encryptedRecoveryPhrase: isInMemoryWallet(wallet) ? wallet.encryptedSecrets.keyMaterial : undefined
encryptedRecoveryPhrase: isInMemoryWallet(wallet) ? wallet.encryptedSecrets.keyMaterial : undefined,
blockchain: isBitcoinWallet(wallet) ? 'Bitcoin' : 'Cardano',
walletType: wallet.type
})
)
)
Expand Down
6 changes: 5 additions & 1 deletion v1/apps/browser-extension-wallet/src/utils/lmp.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,18 @@
// mostly duplicated in v1 and lmp module, could be a shared library
import { RemoteApiProperties, RemoteApiPropertyType } from '@cardano-sdk/web-extension';
import { RemoteApiProperties, RemoteApiPropertyType, WalletType } from '@cardano-sdk/web-extension';
import { Observable } from 'rxjs';
import { storage } from 'webextension-polyfill';
import { Language } from '@lace/translation';

export type BlockchainName = 'Bitcoin' | 'Cardano' | 'Midnight';

export type LmpBundleWallet = {
walletId: string;
walletName: string;
walletIcon: string;
encryptedRecoveryPhrase?: string;
blockchain: BlockchainName;
walletType: WalletType;
};

export type BundleAppApi = {
Expand Down
3 changes: 2 additions & 1 deletion ...on-wallet/src/views/browser-view/features/dapp/explorer/styles/themes/_shared-colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ $data: (
'pink-10': rgba(255, 84, 112, 0.1),
'orange': #ff8e3c,
'green': #2cb67d,
'blue': #3489f7
'blue': #3489f7,
'bright-blue': #0000FE
);
3 changes: 2 additions & 1 deletion v1/packages/common/src/ui/styles/themes/_shared-colors.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,6 @@ $data: (
'pink-10': rgba(255, 84, 112, 0.1),
'orange': #ff8e3c,
'green': #2cb67d,
'blue': #3489f7
'blue': #3489f7,
'bright-blue': #0000FE
);
Loading