Feat/lw 12399 sign multisig tx with hw #1768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vetalcore
requested review from
szymonmaslowski,
przemyslaw-wlodek and
greatertomi
|
vetalcore
force-pushed
the
feat/lw-12398-enable-add-shared-wallet-for-hw
branch
from
57530df to
e596784
Compare
Base automatically changed from
feat/lw-12398-enable-add-shared-wallet-for-hw
to
main
March 14, 2025 12:26
vetalcore
force-pushed
the
feat/lw-12399-sign-multisig-tx-with-hw
branch
2 times, most recently
from
8d36ceb to
f1034d9
Compare
Allure Report
processReports: ✅ test report for c3d85e88
|
AngelCastilloB
force-pushed
the
feat/lw-12399-sign-multisig-tx-with-hw
branch
5 times, most recently
from
6f0d7d9 to
edad259
Compare
vetalcore
force-pushed
the
feat/lw-12399-sign-multisig-tx-with-hw
branch
4 times, most recently
from
2a8d28e to
f4342f3
Compare
vetalcore
force-pushed
the
feat/lw-12399-sign-multisig-tx-with-hw
branch
from
f4342f3 to
c3d85e8
Compare
|
przemyslaw-wlodek
approved these changes
Jun 13, 2025
| @@ -114,22 +113,30 @@ const waitForTabLoad = (tab: Tabs.Tab) => | |||
| * @param activeWallet | |||
| * @returns {Bip32WalletAccount<Wallet.AccountMetadata>} | undefined | |||
| */ | |||
| export const getParentWalletCIP1854Account = ({ | |||
| export const getParentWalletForCIP1854Account = ({ | |||
There was a problem hiding this comment.
Should we remove Account from that name? It now returns the wallet and account.
| @@ -1,6 +1,7 @@ | |||
| /* eslint-disable @typescript-eslint/no-redundant-type-constituents */ | |||
| /* eslint-disable @typescript-eslint/no-unsafe-enum-comparison */ | |||
| /* eslint-disable unicorn/no-null */ | |||
| /* eslint-disable @typescript-eslint/no-redundant-type-constituents */ | |||
There was a problem hiding this comment.
Is it a leftover? 🤔 Seems we don't have an error there (or GH is not showing it?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
getParentWalletCIP1854Accountto also return parent walletTesting
Screenshots
Attach screenshots here if implementation involves some UI changes