fix: [lw-12155] handle page refresh in dapp connector#1688
Merged
Conversation
Contributor
Allure Report
processReports: ✅ test report for 3e959e43
|
pczeglik-iohk
approved these changes
Feb 4, 2025
Contributor
pczeglik-iohk
left a comment
pczeglik-iohk
left a comment
There was a problem hiding this comment.
Code looks good @vetalcore
| expect(setNextViewMock).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| test('Should reject transaction if unmonted', async () => { |
vetalcore
force-pushed
the
fix/lw-12155-handle-page-refresh-in-dapp-connector
branch
2 times, most recently
from
4877a68 to
80e1ee7
Compare
vetalcore
force-pushed
the
fix/lw-12155-handle-page-refresh-in-dapp-connector
branch
from
80e1ee7 to
3e959e4
Compare
|
vetalcore
deleted the
fix/lw-12155-handle-page-refresh-in-dapp-connector
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
beforeunloadevent ❌:awaitinside the callbackwindow.close()doesn't work inside the callbacktrueis returned in the callback, with no ability to provide custom messaging (deprecated in chrome starting from version 51 …)unloadevent ✅:awaitinside the callbackwindow.close()works inside the callbackTesting
Scope
Important
Since we cannot
awaitin the callback, please make sure thetxwas properly rejected before dapp window is closed.*Screenshots
Attach screenshots here if implementation involves some UI changes