feat: [LW-12136] enable setting logging level in the application #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greatertomi
force-pushed
the
feat/lw-12136-log-level-selection
branch
2 times, most recently
from
ced48b3 to
002e672
Compare
greatertomi
changed the title
greatertomi
force-pushed
the
feat/lw-12136-log-level-selection
branch
from
002e672 to
5cb9603
Compare
Allure Report
processReports: ✅ test report for ed97bfc9
|
greatertomi
force-pushed
the
feat/lw-12136-log-level-selection
branch
4 times, most recently
from
3a9fd12 to
cade8b8
Compare
vetalcore
approved these changes
Jan 31, 2025
vetalcore
requested changes
Jan 31, 2025
...ser-extension-wallet/src/views/browser-view/features/settings/components/SettingsLogging.tsx
Outdated
Show resolved
Hide resolved
greatertomi
force-pushed
the
feat/lw-12136-log-level-selection
branch
from
cade8b8 to
7854011
Compare
|
vetalcore
approved these changes
Jan 31, 2025
greatertomi
commented
Jan 31, 2025
| return ( | ||
| <SettingsCard> | ||
| <Title level={5} className={styles.heading5} data-testid={'debugger-heading'}> | ||
| {t('browserView.settings.debugging.title')} |
There was a problem hiding this comment.
@rhyslbw. The section title for the "Debugging" text
greatertomi
commented
Jan 31, 2025
| } | ||
| data-testid="settings-logging-level-section" | ||
| > | ||
| {t('browserView.settings.debugging.title')} |
There was a problem hiding this comment.
@rhyslbw The settings title for the "Debugging" text. They use the same translation key as they are the same text.
rhyslbw
requested changes
Jan 31, 2025
greatertomi
force-pushed
the
feat/lw-12136-log-level-selection
branch
from
ed97bfc to
40a625d
Compare
rhyslbw
requested changes
Jan 31, 2025
| @@ -279,6 +279,8 @@ | |||
| "browserView.settings.preferences.title": "Preferences", | |||
| "browserView.settings.preferences.betaProgram.description": "Test out new features and help us improve the product experience", | |||
| "browserView.settings.preferences.betaProgram.title": "Beta Program", | |||
| "browserView.settings.preferences.debugging.title": "Debugging", | |||
| "browserView.settings.preferences.debugging.description": "Enable debugging logs in the console", | |||
There was a problem hiding this comment.
Suggested change
| "browserView.settings.preferences.debugging.description": "Enable debugging logs in the console", | |
| "browserView.settings.preferences.debugging.description": "Enable verbose console logging", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Proposed solution
Explain how does this PR solves the problem stated in JIRA ticket.
You can also enumerate different alternatives considered while approaching this task.
Testing
Describe here, how the new implementation can be tested.
Provide link or briefly describe User Acceptance Criteria/Tests that need to be met
Screenshots