Timeout removePathForcibly in moduleWorkspace
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/timeout-removePathForcibly
branch
from
9b00685 to
7a3250b
Compare
newhoggy
force-pushed
the
newhoggy/timeout-removePathForcibly
branch
from
7a3250b to
cdbc1a4
Compare
newhoggy
changed the title
removePathForcibly in moduleWorkspace
carbolymer
reviewed
Jun 30, 2025
Comment on lines
+213
to
+218
| GHC.withFrozenCallStack $ do | ||
| result <- try (liftIO (IO.timeout (5 * 1000) (IO.removePathForcibly ws))) | ||
| case result of | ||
| Right (Just ()) -> return () | ||
| Right Nothing -> pure () | ||
| Left (_ :: IOException) -> do |
There was a problem hiding this comment.
Readability could be improved here:
Suggested change
| GHC.withFrozenCallStack $ do | |
| result <- try (liftIO (IO.timeout (5 * 1000) (IO.removePathForcibly ws))) | |
| case result of | |
| Right (Just ()) -> return () | |
| Right Nothing -> pure () | |
| Left (_ :: IOException) -> do | |
| GHC.withFrozenCallStack $ do | |
| catch | |
| (timeout (5_000) (liftIO $ IO.removePathForcibly ws)) | |
| $ \(_ :: IOException) -> do |
from lifted-base: catch, timeout.
5 ms seems to be not much here. I'd increase it an order of magnitude, just to be on the safe side.
carbolymer
reviewed
Jun 30, 2025
| Left (_ :: IOException) -> do | ||
| if retries > 0 | ||
| then do | ||
| liftIO (IO.threadDelay 100000) -- wait 100ms before retrying |
There was a problem hiding this comment.
Suggestion: use lifted-base:
Suggested change
| liftIO (IO.threadDelay 100000) -- wait 100ms before retrying | |
| threadDelay 100_000 -- wait 100ms before retrying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.