Skip to content

Bootstrap with ghc966 #2338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

TravisWhitaker
Copy link
Contributor

No description provided.

@TravisWhitaker
Copy link
Contributor Author

Meant to fix #2337

@TravisWhitaker
Copy link
Contributor Author

Please double-check my work; I'm not terribly familiar with the materialization machinery and cargo-culted this based on what error messages told me.

hamishmack added a commit that referenced this pull request Mar 23, 2025
Maintaining these plans is a bit difficult.  For instance with #2338 the use of GHC 9.6.6 instead of 9.6.4 for building hadrian requires different plans for 9.8.2 and 9.8.4.

Now that we are using a prebuilt static version of nix-tools, there should be less overhead in calculating these plans.
@hamishmack
Copy link
Collaborator

We probably still want to use 9.6.4 when 9.6.6 is not present in nixpkgs. Something like:

       compiler-nix-name =
         if builtins.compareVersions ghc-version "9.4.7" < 0
           then "ghc928"
+        else if buildPackages.haskell.compiler ? ghc966
+          then "ghc966"
         else if buildPackages.haskell.compiler ? ghc964
           then "ghc964"
         else "ghc962";

I spent some time trying to update the materializations and it's a bit of a nightmare to get right. In particular the plans for 9.8.2 and 9.8.4 versions of hadrian (built with 9.6.6) are different (where they were the same for 9.6.4). I think we should just drop the plans for now, see #2339. We can put them back if it turns out to cause significant evaluation time slow downs.

hamishmack added a commit that referenced this pull request Mar 28, 2025
Maintaining these plans is a bit difficult.  For instance with #2338 the use of GHC 9.6.6 instead of 9.6.4 for building hadrian requires different plans for 9.8.2 and 9.8.4.

Now that we are using a prebuilt static version of nix-tools, there should be less overhead in calculating these plans.
@hamishmack
Copy link
Collaborator

Now that #2339 is merged I have opened #2342 to replace this PR.

@hamishmack hamishmack closed this Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants