-
Notifications
You must be signed in to change notification settings - Fork 9
feat(cat-voices): catalyst compression with rust #3370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cat-voices): catalyst compression with rust #3370
Conversation
…ompression-with-rust # Conflicts: # Earthfile # catalyst-gateway/event-db/Earthfile # catalyst-gateway/tests/Earthfile # catalyst_voices/packages/libs/catalyst_cardano/catalyst_cardano/wallet-automation/Earthfile # catalyst_voices/packages/libs/catalyst_key_derivation/Earthfile # catalyst_voices/utilities/uikit_example/Earthfile # docs/Earthfile # utilities/docs-preview/Earthfile
…ompression-with-rust # Conflicts: # Earthfile # catalyst-gateway/Earthfile # catalyst-gateway/event-db/Earthfile # catalyst-gateway/tests/Earthfile # catalyst_voices/Earthfile # catalyst_voices/packages/libs/catalyst_cardano/catalyst_cardano/wallet-automation/Earthfile # catalyst_voices/packages/libs/catalyst_key_derivation/Earthfile # catalyst_voices/packages/libs/catalyst_key_derivation/rust/Earthfile # catalyst_voices/utilities/uikit_example/Earthfile # docs/Earthfile # utilities/docs-preview/Earthfile
…ompression-with-rust
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/feat/catalyst-compression-with-rust |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From Dart perspective only formatting is mixed up a little bit. But I'm not sure if these files are generated and this the answer to that formatting problem
catalyst_voices/packages/libs/catalyst_compression/android/build.gradle
Outdated
Show resolved
Hide resolved
...oices/packages/libs/catalyst_compression/cargokit/build_tool/lib/src/artifacts_provider.dart
Show resolved
Hide resolved
...oices/packages/libs/catalyst_compression/cargokit/build_tool/lib/src/artifacts_provider.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to build and run same code on web android and iOS. Very important PR!
One small comment tho
LGTM
catalyst_voices/packages/libs/catalyst_compression/lib/src/rust_initializer.dart
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rust part LGTM, but dont forget to change cat-ci version to some release from feat/catalyst-compression-setup
…ompression-with-rust
Description
catalyst_compression
with rust using flutter_rust_bridge.catalyst_compression
. The federated packages published to pub.dev will be discontinued, onlycatalyst_compression
will remain active.catalyst_key_derivation
.flutter_rust_bridge
since the official version doesn't allow to run two packages built with the tool in the same app on the web platform. Each package exports global modules underwindow.wasm_bindgen
and they conflict with each other. The fork added configuration options to differentiate between modules. The changes done in the fork will be moved to iohk owned repository once it is available. A PR will be opened to merge the changes from the fork to the official version.flutter_rust_bridge
boilerplate that must be committed into the repository. You can skip reviewing it (pattern for these files:**/cargokit/**
).pre-push
tasks in alljustfile
s to make sure all necessary checks are run.Related Issue(s)
Closes #3266
Depends on input-output-hk/catalyst-ci#448
Please confirm the following checks