feat(rust): Implement CBOR encoding/decoding for the catalyst-voting types #705
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
added
the
squad: gatekeepers
Mr-Leshiy
requested changes
Dec 12, 2025
Contributor
Mr-Leshiy
left a comment
Mr-Leshiy
left a comment
There was a problem hiding this comment.
What do you think to also remove original implementation to_bytes, from_bytes methods to reduce maintenance issues for future.
I dont think that they are gonna used, the primary implementation I believe is always would an CBOR decoding
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/libs/cbor-encoding-for-catalyst-voting-types |
Contributor
|
✅ Test Report | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement CBOR encoding/decoding for the
catalyst-votingtypes.Related Issue(s)
Part of #657
Related Pull Requests
#678