-
Notifications
You must be signed in to change notification settings - Fork 1
feat(rust/hermes-ipfs): Implement timers for doc-sync #698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bkioshn
wants to merge
13
commits into
main
Choose a base branch
from
feat/doc-sync-timers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
8 tasks
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/libs/feat/doc-sync-timers |
Contributor
|
✅ Test Report | |
Signed-off-by: bkioshn <[email protected]>
This reverts commit 311cab0.
Contributor
Author
|
Decide to use this callback as a function over generic function object due to the complication arise in |
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Signed-off-by: bkioshn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comment me
Request for comments
review me
PR is ready for review
squad: hermetics
Hermes Backend, System Development & Integration Team
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implement timers for doc-sync.
Related Issue(s)
input-output-hk/hermes#703
Description of Changes
Specification can be found here
SyncTimersStatewhere it holds the state of all the timers.newtopicstart_quiet_timer: Start the quiet timer. It should runs the quiet timer in the background and there should be only one quiet timer per channel.run_quiet_timer: Contains a loop that use to control the timerreset_quiet_timer: Use to send a notification when the timer need to be resetstop_quiet_timer: Stop the timer (the timer should be long running)📝 NOTES: The related pull request mention below shows how the timer is used.
Related Pull Requests
input-output-hk/hermes#707
Please confirm the following checks