Skip to content

refactor(rust/signed-doc): Change collabs header to collaborators #395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Jul 3, 2025

Conversation

apskhem
Copy link
Collaborator

@apskhem apskhem commented Jul 1, 2025

Description

!!BREAKING CHANGE!!

  • Changed collabs header to collaborators
  • Changed from the list of String to CatalystId

Related Issue(s)

Closes #387

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@apskhem apskhem self-assigned this Jul 1, 2025
@apskhem apskhem added the do not merge yet PR is not ready to be merged yet label Jul 1, 2025
@apskhem apskhem added this to Catalyst Jul 1, 2025
@apskhem apskhem added the squad: gatekeepers Catalyst App Backend, System Development & Integration Team label Jul 1, 2025
@apskhem apskhem linked an issue Jul 1, 2025 that may be closed by this pull request
@apskhem apskhem moved this from New to 🏗 In progress in Catalyst Jul 1, 2025
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 🔖 Ready in Catalyst Jul 1, 2025
@apskhem apskhem added review me PR is ready for review requires architect review Requires at least 1 architect to sign off on PR before merge. and removed do not merge yet PR is not ready to be merged yet labels Jul 1, 2025
@apskhem apskhem moved this from 🔖 Ready to 👀 In review in Catalyst Jul 1, 2025
@apskhem apskhem requested a review from Mr-Leshiy July 1, 2025 14:22
@apskhem
Copy link
Collaborator Author

apskhem commented Jul 1, 2025

As I changed collaborators to use CatalystId instead of String, do we want it to be lazy or eager decoding? [do we want to parse cat-id at the moment we decode cbor (eager), or do we want to parse it when we first access thecollaborators part (lazy)] As this commit, I did eager decoding. But want opinion from others.

Copy link
Contributor

github-actions bot commented Jul 1, 2025

Test Report | ${\color{lightgreen}Pass: 360/360}$ | ${\color{red}Fail: 0/360}$ |

Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@github-project-automation github-project-automation bot moved this from 👀 In review to 🔖 Ready in Catalyst Jul 2, 2025
@apskhem apskhem requested a review from Mr-Leshiy July 2, 2025 12:23
@apskhem apskhem moved this from 🔖 Ready to 👀 In review in Catalyst Jul 2, 2025
@apskhem apskhem removed the requires architect review Requires at least 1 architect to sign off on PR before merge. label Jul 2, 2025
@apskhem apskhem merged commit 201b858 into feat/new-cat-signed-doc Jul 3, 2025
24 checks passed
@apskhem apskhem deleted the fix/collabs-header branch July 3, 2025 12:02
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Catalyst Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review squad: gatekeepers Catalyst App Backend, System Development & Integration Team
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

"collaborators" metadata field
3 participants