Skip to content

feat: Add protocol parameter REST endpoints with optional historical storage (WIP) #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

whankinsiv
Copy link
Collaborator

Opening as a draft to get initial feedback. Updating OpenAPI specification and final testing will be done tomorrow.
This PR:

@whankinsiv
Copy link
Collaborator Author

This PR is ready for review, pending the merge of #89 to resolve openapi.yaml conflicts.

Signed-off-by: William Hankins <[email protected]>
@whankinsiv
Copy link
Collaborator Author

Merge conflicts are now resolved. Moving to ready for review.

@whankinsiv whankinsiv marked this pull request as ready for review July 21, 2025 21:03
@@ -48,13 +61,21 @@ impl ParametersStateConfig {
actual
}

fn conf_bool(config: &Arc<Config>, keydef: (&str, bool)) -> bool {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking these config helpers should be in common really. If only we could attach helpers to Config itself!

@sandtreader sandtreader merged commit b9644c6 into input-output-hk:main Jul 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants