feat: Add protocol parameter REST endpoints with optional historical storage (WIP) #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…storage (WIP) Signed-off-by: William Hankins <[email protected]>
Signed-off-by: William Hankins <[email protected]>
|
This PR is ready for review, pending the merge of #89 to resolve |
Signed-off-by: William Hankins <[email protected]>
|
Merge conflicts are now resolved. Moving to ready for review. |
sandtreader
reviewed
Jul 22, 2025
| @@ -48,13 +61,21 @@ impl ParametersStateConfig { | |||
| actual | |||
| } | |||
|
|
|||
| fn conf_bool(config: &Arc<Config>, keydef: (&str, bool)) -> bool { | |||
There was a problem hiding this comment.
Thinking these config helpers should be in common really. If only we could attach helpers to Config itself!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening as a draft to get initial feedback. Updating OpenAPI specification and final testing will be done tomorrow.
This PR:
active_epochand optionalparameter_historyfields toparameters_state.store-historyconfig option inomnibus.tomlto enable historical protocol parameters storage./epoch/parametersand/epochs/{epoch_number}/parametersREST endpoints mentioned in Fix REST interface in ParameterState #86 & Historical REST interface for ParameterState #87.