New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Connect requiring signing key in dev mode #114

Merged

amh4r merged 2 commits into main from connect-dev-mode

Mar 14, 2025

Contributor

amh4r commented Mar 13, 2025

Fix Connect requiring signing key in dev mode.
Fix Connect panicking when no logger passed to client.
Fix APIBaseURL not used when in dev mode.
Fix env var bleeding during tests.


          Fix Connect requiring signing key in dev mode

a75b3ad

amh4r requested a review from BrunoScheufler

March 13, 2025 19:45


          Fix test

258d5ed

tonyhb reviewed

View reviewed changes

client.go

@@ @@ -109,6 +109,10 @@ func NewClient(opts ClientOpts) (Client, error) { @@
               		return nil, err
               	}
+              	if opts.Logger == nil {
+              		opts.Logger = slog.Default()

Contributor

tonyhb Mar 13, 2025

👍

tonyhb approved these changes

View reviewed changes

BrunoScheufler approved these changes

View reviewed changes

amh4r merged commit c20ca66 into main

7 checks passed

amh4r deleted the connect-dev-mode branch

March 14, 2025 10:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet