Skip to content

Added support for Override/AppendUserAgent in iOS, matching cordova-i… #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Added support for Override/AppendUserAgent in iOS, matching cordova-i… #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/ios/CDVThemeableBrowser.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ - (CDVThemeableBrowser*)initWithWebView:(UIWebView*)theWebView
return self;
}

- (id)settingForKey:(NSString*)key
{
return [self.commandDelegate.settings objectForKey:[key lowercaseString]];
}

- (void)onReset
{
[self close:nil];
Expand Down Expand Up @@ -216,9 +221,18 @@ - (void)openInThemeableBrowser:(NSURL*)url withOptions:(NSString*)options
}

if (self.themeableBrowserViewController == nil) {
NSString* originalUA = [CDVUserAgentUtil originalUserAgent];
NSString* userAgent = [CDVUserAgentUtil originalUserAgent];
NSString* overrideUserAgent = [self settingForKey:@"OverrideUserAgent"];
if (overrideUserAgent) {
userAgent = overrideUserAgent;
} else {
NSString* appendUserAgent = [self settingForKey:@"AppendUserAgent"];
if(appendUserAgent) {
userAgent = [userAgent stringByAppendingString: appendUserAgent];
}
}
self.themeableBrowserViewController = [[CDVThemeableBrowserViewController alloc]
initWithUserAgent:originalUA prevUserAgent:[self.commandDelegate userAgent]
initWithUserAgent:userAgent prevUserAgent:[self.commandDelegate userAgent]
browserOptions: browserOptions
navigationDelete:self
statusBarStyle:[UIApplication sharedApplication].statusBarStyle];
Expand Down