Netting Project: PR 1 of n #409
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tracked in #410 |
sbellem
reviewed
Dec 9, 2019
| rm -rf data/ | ||
|
|
||
| gen_data: | ||
| python3 scripts/generate_data.py |
There was a problem hiding this comment.
Just to remain consistent with the code base, let's use Makefile instead of makefile. Although both work, the GNU make manual recommends Makefile:
We recommend
Makefilebecause it appears prominently near the beginning of a directory listing, right near other important files such asREADME.
sbellem
reviewed
Dec 9, 2019
| bal_file_prefix = "party_" | ||
| bal_file_suffix = "_bal_data.csv" | ||
|
|
||
| NETTING_BASE_DIR = "/usr/src/HoneyBadgerMPC/apps/netting/" |
There was a problem hiding this comment.
Is there a plan to have more files under apps/netting/config/? If not, apps/netting/config.py is sufficient and makes the code simpler.
sbellem
reviewed
Dec 9, 2019
| shutil.rmtree(path) | ||
| except Exception as e: | ||
| logging.exception(e) | ||
| pass |
There was a problem hiding this comment.
The pass is not needed 😄 .
|
Closing as we're working on another branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project will probably have lots of PRs coming the way. I am making small PRs for fast development and easy review/merges.
Although this PR does not add any functionality by itself, I think merging this will save development and review time in the future. Let me know if you have any issues with this approach. And we can decide on another way of doing this.
I am also trying to maintain this project as a standalone project without reliance on this codebase, but I don't think that effort is warranted for now. I am using a custom .gitignore file for this project.
As of now, this PR supports:
Creation of transaction and balances from initial values
Client reading the data from files and saving in-memory structures.
Tests for the correct functioning of these files