feat: example code to sign & send Orders #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anna-carroll
commented
May 1, 2025
•
anna-carroll
commented
- construct a simple example Order
- sign the Order
- send the Order
anna-carroll
force-pushed
the
anna/order-ex
branch
from
a32f71c to
c042ebe
Compare
Evalir
requested changes
May 1, 2025
Comment on lines
+16
to
+17
| /// Empty main to silence clippy. | ||
| fn main() {} |
There was a problem hiding this comment.
let's put the main fn at the bottom
Comment on lines
+12
to
+14
| fn token_amount(amount: u64, decimals: u32) -> U256 { | ||
| U256::from(amount * 10u64.pow(decimals)) | ||
| } |
There was a problem hiding this comment.
Use ParseUnits from alloy::primitives to perform this conversion—no need to implement yourself
Evalir
reviewed
May 1, 2025
Comment on lines
+92
to
+101
| // input is 1 USDC on the rollup | ||
| let input = Input { token: self.ru_usdc_address, amount: one_usdc }; | ||
|
|
||
| // output is 1 USDC on the host chain | ||
| let output = Output { | ||
| token: self.host_usdc_address, | ||
| amount: one_usdc, | ||
| chainId: self.host_chain_id as u32, | ||
| recipient: self.signer.address(), | ||
| }; |
There was a problem hiding this comment.
unrelated to this pr, but i still think we should have builder types for these so we don't have to declare them like this
There was a problem hiding this comment.
agree, I started working on that code already but was prioritizing this first
|
|
||
| /// Get an example Order which swaps 1 USDC on the rollup for 1 USDC on the host. | ||
| fn example_order(&self) -> Order { | ||
| let usdc_decimals: u32 = 6; |
There was a problem hiding this comment.
let's make this a const at the top
prestwich
reviewed
May 1, 2025
| /// Get an example Order which swaps 1 USDC on the rollup for 1 USDC on the host. | ||
| fn example_order(&self) -> Order { | ||
| let usdc_decimals: u32 = 6; | ||
| let one_usdc = token_amount(1, usdc_decimals); |
There was a problem hiding this comment.
why are we calculating this at all? it could be a file-level const const ONE_USDC = uint!(1_000_000_U256);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.