Repository navigation
feat: example code to sign & send Orders - #44
Conversation
a32f71c to
c042ebe
Compare
470003c to
a0b5e79
Compare
a0b5e79 to
0118576
Compare
| } | ||
|
|
||
| /// Get the Order contract address for the given chain id. | ||
| pub const fn orders_for(&self, chain_id: u64) -> Option<Address> { |
There was a problem hiding this comment.
not sure if this is the most idiomatic way to do this?
There was a problem hiding this comment.
the fn signature is idiomatic, but it's kinda weird in that there are exactly 2 choices, and the caller will always know which they want, so why do we allow passing an arbitrary chain id? caller should probably use .host_orders() or .rollup_orders() directly instead?
There was a problem hiding this comment.
it's kinda fine this way I guess? the agg may contain invalid or junk data and this is one of the better ways to handle that I suppose
There was a problem hiding this comment.
yeah i wish we didn't have an arbitrary chain id here, but james's argument is sound
Evalir
left a comment
Evalir
left a comment
There was a problem hiding this comment.
basically lgtm, just the convo about the chain id
| } | ||
|
|
||
| /// Get the Order contract address for the given chain id. | ||
| pub const fn orders_for(&self, chain_id: u64) -> Option<Address> { |
There was a problem hiding this comment.
yeah i wish we didn't have an arbitrary chain id here, but james's argument is sound
Uh oh!
There was an error while loading. Please reload this page.