feat: example code to sign & send Orders #44
Conversation
anna-carroll
force-pushed
the
anna/order-ex
branch
from
a32f71c to
c042ebe
Compare
anna-carroll
force-pushed
the
anna/order-ex
branch
from
470003c to
a0b5e79
Compare
anna-carroll
force-pushed
the
anna/order-ex
branch
from
a0b5e79 to
0118576
Compare
| @@ -87,6 +87,17 @@ impl SignetSystemConstants { | |||
| self.host.is_system_contract(address) | |||
| } | |||
|
|
|||
| /// Get the Order contract address for the given chain id. | |||
| pub const fn orders_for(&self, chain_id: u64) -> Option<Address> { | |||
There was a problem hiding this comment.
not sure if this is the most idiomatic way to do this?
There was a problem hiding this comment.
the fn signature is idiomatic, but it's kinda weird in that there are exactly 2 choices, and the caller will always know which they want, so why do we allow passing an arbitrary chain id? caller should probably use .host_orders() or .rollup_orders() directly instead?
There was a problem hiding this comment.
it's kinda fine this way I guess? the agg may contain invalid or junk data and this is one of the better ways to handle that I suppose
There was a problem hiding this comment.
yeah i wish we didn't have an arbitrary chain id here, but james's argument is sound
| @@ -87,6 +87,17 @@ impl SignetSystemConstants { | |||
| self.host.is_system_contract(address) | |||
| } | |||
|
|
|||
| /// Get the Order contract address for the given chain id. | |||
| pub const fn orders_for(&self, chain_id: u64) -> Option<Address> { | |||
There was a problem hiding this comment.
yeah i wish we didn't have an arbitrary chain id here, but james's argument is sound
Uh oh!
There was an error while loading. Please reload this page.