feat: example code for Fillers #43
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anna-carroll
force-pushed
the
anna/filler-ex
branch
from
b178775 to
720bcdd
Compare
Closed
dylanlott
reviewed
May 1, 2025
| use std::collections::HashMap; | ||
|
|
||
| /// Multiplier for converting gwei to wei. | ||
| const GWEI_TO_WEI: u64 = 1_000_000_000; |
There was a problem hiding this comment.
Nit: Should use the alloy constant for this value instead of declaring it ourselves.
dylanlott
reviewed
May 1, 2025
Evalir
reviewed
May 1, 2025
dylanlott
reviewed
May 1, 2025
prestwich
reviewed
May 1, 2025
| impl From<Vec<SignedOrder>> for AggregateOrders { | ||
| fn from(orders: Vec<SignedOrder>) -> Self { | ||
| let mut agg = AggregateOrders::new(); | ||
| for order in orders { |
There was a problem hiding this comment.
whole function can be replaced by
.iter().collect()
prestwich
reviewed
May 1, 2025
| fn from(orders: Vec<RollupOrders::Order>) -> Self { | ||
| let mut agg = AggregateOrders::new(); | ||
| for order in orders { | ||
| agg.ingest(&order); |
There was a problem hiding this comment.
whole function can be replaced by
.iter().collect()
prestwich
reviewed
May 1, 2025
| /// Sign them and encode them for inclusion in a Bundle. | ||
| pub async fn sign_and_encode_txns( | ||
| &self, | ||
| tx_requests: Vec<TransactionRequest>, |
There was a problem hiding this comment.
almost all of your methods should take &[T] instead of Vec<T>
prestwich
reviewed
May 1, 2025
| async fn rollup_txn_requests( | ||
| &self, | ||
| signed_fills: &HashMap<u64, SignedFill>, | ||
| orders: &Vec<SignedOrder>, |
prestwich
reviewed
May 1, 2025
| /// rather than signing a single, aggregate a Fill for each chain, as is done here. | ||
| pub async fn sign_fills( | ||
| &self, | ||
| orders: Vec<SignedOrder>, |
prestwich
reviewed
May 1, 2025
| /// If a single Order is passed to this fn, | ||
| /// Filling Orders individually ensures that even if some Orders are not fillable, others may still mine; | ||
| /// however, it is less gas efficient. | ||
| pub async fn fill(&self, orders: Vec<SignedOrder>) -> Result<(), Error> { |
prestwich
reviewed
May 1, 2025
crates/rpc/examples/filler.rs
Outdated
| /// | ||
| /// Filling Orders individually ensures that even if some Orders are not fillable, others may still mine; | ||
| /// however, it is less gas efficient. | ||
| pub async fn fill_individual(&self, orders:Vec<SignedOrder>) -> Result<(), Error> { |
prestwich
reviewed
May 1, 2025
prestwich
reviewed
May 1, 2025
| let txs = self.sign_and_encode_txns(tx_requests).await?; | ||
|
|
||
| // get the aggregated host fill for the Bundle, if any | ||
| let host_fills = signed_fills.get(&self.host_chain_id).cloned(); |
There was a problem hiding this comment.
you don't need this anymore, so you can remove here to avoid cloning
prestwich
reviewed
May 1, 2025
| } | ||
|
|
||
| // sign a SignedFill for the orders | ||
| let signed_fills = self.sign_fills(orders.clone()).await?; |
There was a problem hiding this comment.
change to borrows so no need to clone
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example code for Fillers of Signet Orders.