feat(calc): manual FromEnv impl
#70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements `FromEnv` manuall for the calculator. It now has the following behavior: - First, the `CHAIN_NAME` environment variable is checked. If it's present, instantiation from the chain name is attempted. - If the `CHAIN_NAME` environment variable is not present, the individual environment variables used to configure the calculator are looked up, and the calculator is instantiated. Any of these missing results in a hard error.
prestwich
reviewed
Sep 10, 2025
Evalir
force-pushed
the
evalir/manual-calc-fromenv
branch
from
b6775cc to
c6eafce
Compare
Evalir
force-pushed
the
evalir/manual-calc-fromenv
branch
from
c6eafce to
7ccb988
Compare
prestwich
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
FromEnvmanually for the calculator. It now has the following behavior:CHAIN_NAMEenvironment variable is checked. If it's present, instantiation from the chain name is attempted.CHAIN_NAMEenvironment variable is not present, the individual environment variables used to configure the calculator are looked up, and the calculator is instantiated. Any of these missing results in a hard error.