fix(code/core-consensus): Reproduce and fix consensus being stuck with byzantine proposer #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 9 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
romac
reviewed
Feb 13, 2025
code/crates/test/app/src/state.rs
Outdated
| @@ -50,12 +50,17 @@ pub struct State { | |||
| // order for each node to likely propose different values at | |||
| // each round. | |||
| fn seed_from_address(address: &Address) -> u64 { | |||
| address.into_inner().chunks(8).fold(0u64, |acc, chunk| { | |||
There was a problem hiding this comment.
Good idea! Maybe we should allow the test framework to trigger such behavior, what do you think? Will think about how to implement that properly
There was a problem hiding this comment.
Yes, let's discuss. Also to figure out how to enable byzantine proposer.
romac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #850
Closes: #857
PR author checklist
For all contributors
For external contributors