Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(code/test): Move max_block_size to test configuration #846

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

ancazamfir
Copy link
Collaborator

Closes: #845


PR author checklist

For all contributors

For external contributors

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.65%. Comparing base (88b4193) to head (bcc9b04).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
- Coverage   81.89%   81.65%   -0.24%     
==========================================
  Files         182      182              
  Lines       16269    16266       -3     
==========================================
- Hits        13323    13282      -41     
- Misses       2946     2984      +38     
Flag Coverage Δ
integration 81.49% <ø> (-0.24%) ⬇️
mbt 8.51% <ø> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
core ∅ <ø> (∅)
engine ∅ <ø> (∅)
app ∅ <ø> (∅)
starknet ∅ <ø> (∅)

@ancazamfir ancazamfir marked this pull request as ready for review February 11, 2025 16:25
@romac romac changed the title chore(code/test): Move max_block_size to test configuration chore(code/test): Move max_block_size to test configuration Feb 11, 2025
@romac romac added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 99124f5 Feb 11, 2025
24 checks passed
@romac romac deleted the anca/max_block_size branch February 11, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Move max_block_size from consensus configuration to test
2 participants