Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(code): Add some unit tests to the core-consensus crate #673

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

romac
Copy link
Member

@romac romac commented Dec 12, 2024

Closes: #431


PR author checklist

@romac romac force-pushed the romac/core-consensus-test branch from faef7d4 to c5545e7 Compare December 12, 2024 17:52
@romac romac added the work in progress Work in progress label Dec 19, 2024
@romac romac force-pushed the romac/core-consensus-test branch from c5545e7 to 803a2c9 Compare January 8, 2025 15:57
@romac romac force-pushed the romac/core-consensus-test branch from 803a2c9 to f4bc22f Compare January 8, 2025 16:00
Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 79.41%. Comparing base (9768451) to head (f4bc22f).
Report is 56 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
code/crates/engine/src/consensus.rs 9.09% 10 Missing ⚠️
code/crates/app/src/spawn.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #673      +/-   ##
==========================================
+ Coverage   79.35%   79.41%   +0.06%     
==========================================
  Files         104      104              
  Lines        9020     9023       +3     
==========================================
+ Hits         7157     7165       +8     
+ Misses       1863     1858       -5     
Flag Coverage Δ
integration 79.12% <8.33%> (+0.06%) ⬆️
mbt 16.59% <ø> (-3.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romac romac changed the title test(code): Add unit tests to consensus crate test(code): Add some unit tests to the core-consensus crate Jan 8, 2025
@romac romac added the code Code/implementation related label Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code Code/implementation related work in progress Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code: Write tests for malachite-consensus
1 participant