Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code: Move max_block_size from consensus configuration to test #845

Closed
ancazamfir opened this issue Feb 11, 2025 · 0 comments · Fixed by #846
Closed

code: Move max_block_size from consensus configuration to test #845

ancazamfir opened this issue Feb 11, 2025 · 0 comments · Fixed by #846
Assignees
@ancazamfir

Comments

@ancazamfir
Copy link
Collaborator

max_block_size configuration should be a test/ app configuration. Consensus does not use it but rather the block builder which is part of the app.
@ancazamfir ancazamfir self-assigned this Feb 11, 2025
@ancazamfir ancazamfir mentioned this issue Feb 11, 2025
Merged
3 tasks
@ancazamfir ancazamfir changed the title code: Remove max_block_size from consensus configuration to test code: Move max_block_size from consensus configuration to test Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ancazamfir ancazamfir

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(code/test): Move max_block_size to test configuration informalsystems/malachite
1 participant
@ancazamfir