Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(edge): Fixes enterprise helm chart to allow config of livenessProbe #671
fix(edge): Fixes enterprise helm chart to allow config of livenessProbe #671
Changes from 6 commits
3689621
58828a7
6d36b0d
9950f1c
4709ded
1623417
66a28e8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the same also need to be placed onto the meta nodes too?
Perhaps that wasn't the original ask, but a slight rejig to allowing something like:
might be quite worthwhile? I'm not authoritative on this though of course 😄
For reference, as the
livenessProbe
field exists in both files:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll go ahead and add to the meta nodes too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdockerty should I be splitting up the livenessProbe or maybe just have a single value in the helm chart? If customers indicate they want it split we can do so but as of right now I think the customer is just wanting to adjust the data nodes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case I think going to satisfy what a customer wants is fine, as it is a quick win, although it isn't my call too unfortunately. Might be worth checking with Geoffrey on that one 😄