Skip to content

Commit

Permalink
Support new versions of money gem
Browse files Browse the repository at this point in the history
  • Loading branch information
lovro-bikic committed Jun 21, 2024
1 parent c903c57 commit accad08
Show file tree
Hide file tree
Showing 5 changed files with 18 additions and 12 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
money: ['6.14.0', '6.14.1', '6.16.0']
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
money: ['6.14.0', '6.14.1', '6.16.0', '6.17.0', '6.18.0', '6.19.0']
money_rails: ['1.15.0']
rails: ['~> 5.2.0', '~> 6.0.0', '~> 6.1.0', '~> 7.0.0', '~> 7.1.0']
exclude:
Expand All @@ -42,6 +42,8 @@ jobs:
rails: '~> 5.2.0'
- ruby: '3.2'
rails: '~> 5.2.0'
- ruby: '3.3'
rails: '~> 5.2.0'
steps:
- uses: actions/checkout@v4
- name: Set up Ruby
Expand All @@ -60,8 +62,8 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
money: ['6.14.0', '6.14.1', '6.16.0']
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
money: ['6.14.0', '6.14.1', '6.16.0', '6.17.0', '6.18.0', '6.19.0']
steps:
- uses: actions/checkout@v4
- name: Set up Ruby
Expand All @@ -80,7 +82,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2']
ruby: ['2.6', '2.7', '3.0', '3.1', '3.2', '3.3']
money_rails: ['1.15.0']
mongodb: ['4.4']
steps:
Expand Down
4 changes: 2 additions & 2 deletions Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ PATH
remote: .
specs:
money_with_date (0.3.0)
money (>= 6.14.0, <= 6.16.0)
money (>= 6.14.0, <= 6.19.0)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -70,4 +70,4 @@ DEPENDENCIES
rubocop-rspec

BUNDLED WITH
2.3.7
2.5.14
7 changes: 4 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -333,20 +333,21 @@ Money.default_date_column = nil

`money_with_date` has the following version requirements:
- Ruby: **>= 2.6.0**
- money: **>= 6.14.0** and **<= 6.16.0**
- money: **>= 6.14.0** and **<= 6.19.0**
- money-rails: **1.15.0**

The gem has been tested against all possible combinations of supported Ruby, Rails, money, and money-rails versions:
- Ruby: `2.6`, `2.7`, `3.0`, `3.1` and `3.2`
- Ruby: `2.6`, `2.7`, `3.0`, `3.1`, `3.2` and `3.3`
- Rails: `~> 5.2.0`, `~> 6.0.0`, `~> 6.1.0`, `~> 7.0.0` and `~> 7.1.0`
- money: `6.14.0`, `6.14.1`, and `6.16.0`
- money: `6.14.0`, `6.14.1`, `6.16.0`, `6.17.0`, `6.18.0` and `6.19.0`
- money-rails: `1.15.0`

The following combinations have been excluded from the test matrix because of incompatibility:
- Ruby `2.6` with Rails `~> 7.0.0` and `~> 7.1.0`
- Ruby `3.0` with Rails `~> 5.2.0`
- Ruby `3.1` with Rails `~> 5.2.0`
- Ruby `3.2` with Rails `~> 5.2.0`
- Ruby `3.3` with Rails `~> 5.2.0`

In addition to running its own test suite, the CI for this gem also runs [money's](https://github.com/RubyMoney/money/tree/main/spec) and [money-rails's](https://github.com/RubyMoney/money-rails/tree/main/spec) test suites with this gem loaded, to prevent regressions. This has been achieved by cloning their test suites from GitHub and requiring this gem in their spec files. For technical information, check the CI [workflow](.github/workflows/ci.yml).

Expand Down
5 changes: 4 additions & 1 deletion bin/prepare_money_specs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ money_version = ENV.fetch("MONEY_VERSION", nil)
version_refs = {
"6.14.0" => "e26e222af68bf9b89ac52e1c6e5b2562a0577a8e",
"6.14.1" => "9bb10c79e24abb62ed5a0d1f88876cd459b307b7",
"6.16.0" => "ca59ced949e4e818262a59ffbcad3ec54affa81f"
"6.16.0" => "ca59ced949e4e818262a59ffbcad3ec54affa81f",
"6.17.0" => "35ced98c83d562b40623a985861e301a836327b5",
"6.18.0" => "f5699476c629d291b943ebbe495561d287599ed4",
"6.19.0" => "faec0fbb7cb10646453c5ef6644289d83615b4fe"
}

archive_folder_path = "#{__dir__}/../tmp"
Expand Down
2 changes: 1 addition & 1 deletion lib/money_with_date/version.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ module MoneyWithDate
MINIMUM_MONEY_VERSION = "6.14.0"
MINIMUM_MONEY_RAILS_VERSION = "1.15.0"

MAXIMUM_MONEY_VERSION = "6.16.0"
MAXIMUM_MONEY_VERSION = "6.19.0"
MAXIMUM_MONEY_RAILS_VERSION = "1.15.0"
end

0 comments on commit accad08

Please sign in to comment.