Add Secure and SameSite parameters as options to cookie method #847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goranalkovic-infinum
requested changes
Jan 28, 2025
scripts/helpers/cookies.js
Outdated
Comment on lines
41
to
47
| const cookieParts = [ | ||
| `${key}=${value}`, | ||
| `expires=${expires.toUTCString()}`, | ||
| `SameSite=${sameSite}`, | ||
| pathValue, | ||
| domainValue, | ||
| ]; |
There was a problem hiding this comment.
Please rewrite this so it's an object instead of array of strings
goranalkovic-infinum
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We started getting errors from BugSnag for unsecured cookies, so I solved this on a project, but consider we should also have this as an option in FE Libs cookie helper.
This will set
sameSitedefault toLax(which is already default, but not in all browsers, like Safari or Firefox). Means that cookie is not sent on cross-site requests by default. More here.Also, set
Secureattribute by default, which indicates that the cookie is sent to the server only when a request is made with the https: scheme (except on localhost), and therefore, is more resistant to man-in-the-middle attacks.