Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix data race in MemoryIndexer::Dump #2422

Merged
merged 1 commit into from
Jan 6, 2025
Merged

Fix data race in MemoryIndexer::Dump #2422

merged 1 commit into from
Jan 6, 2025

Conversation

yangzq50
Copy link
Contributor

@yangzq50 yangzq50 commented Jan 3, 2025 •
edited
Loading

What problem does this PR solve?

Fix data race in MemoryIndexer::Dump

Type of change

  • Bug Fix (non-breaking change which fixes an issue)

@yangzq50 yangzq50 added the slow-test To trigger slow test label Jan 3, 2025
@yangzq50 yangzq50 requested a review from yuzhichang January 3, 2025 10:04
@yangzq50 yangzq50 added the ci PR can be test label Jan 3, 2025
@yangzq50 yangzq50 changed the title Fix slow test data race Fix data race in MemoryIndexer::Dump Jan 3, 2025
@yangzq50 yangzq50 added ci PR can be test and removed ci PR can be test labels Jan 3, 2025
@yuzhichang
Copy link
Member

LGTM

@yangzq50 yangzq50 added ci PR can be test and removed ci PR can be test labels Jan 4, 2025
@JinHai-CN JinHai-CN merged commit 7830b9b into infiniflow:main Jan 6, 2025
6 of 10 checks passed
@yangzq50 yangzq50 deleted the fix_slow_test branch January 6, 2025 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuzhichang yuzhichang Awaiting requested review from yuzhichang

Assignees
No one assigned
Labels
ci PR can be test slow-test To trigger slow test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yangzq50 @yuzhichang @JinHai-CN