fix: squeeze only axis 0 in dot_likelihood to prevent shape mismatch#405
Open
lingxiu58 wants to merge 1 commit into
Open
fix: squeeze only axis 0 in dot_likelihood to prevent shape mismatch#405lingxiu58 wants to merge 1 commit into
lingxiu58 wants to merge 1 commit into
Conversation
np.squeeze(X) removes all size-1 dimensions, which incorrectly collapses the trailing dimension when A has shape (1, N, 1). Using np.squeeze(X, axis=0) preserves the intended (N, 1) output shape. Fixes infer-actively#171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
np.squeeze(X)indot_likelihood()(pymdp/legacy/maths.py:245) removes all size-1 dimensions. WhenAhas shape(1, N, 1)(e.g., single-modality with trailing dimension), this collapses both axes, returning(N,)instead of the expected(N, 1). This causes shape mismatches in downstreamcalc_free_energy()calls withinfpi.py.Fix
Restricts squeeze to axis 0 only, preserving the trailing dimension and maintaining shape consistency.
Reproduction
Fixes #171