Skip to content

Migrate to pnpm #2276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jul 15, 2025
Merged

Migrate to pnpm #2276

merged 34 commits into from
Jul 15, 2025

Conversation

jrmajor
Copy link
Contributor

@jrmajor jrmajor commented Mar 16, 2025

Replaces #1875.

@jrmajor jrmajor force-pushed the pnpm branch 5 times, most recently from 3703c73 to be24af3 Compare March 16, 2025 16:15
@pascalbaljet
Copy link
Member

Thanks for this, @jrmajor, looks great! I've updated it to reflect the latest changes and added some more scripts.

Just wondering if you thought there was anything left to do since you marked it as draft?

@jrmajor
Copy link
Contributor Author

jrmajor commented Jun 6, 2025

Thank you @pascalbaljet! IIRC, i just wanted to do some more testing to make sure that this doesn't break anything. Let me do a quick self-review to see if there are any todos left.

@jrmajor jrmajor marked this pull request as ready for review June 6, 2025 11:52
@jrmajor
Copy link
Contributor Author

jrmajor commented Jun 6, 2025

@pascalbaljet Ready for review. Are the test:*:serve scripts needed for something? Seems like that server is only used by Playwright, which doesn't use these scripts anyway.

@pascalbaljet
Copy link
Member

@pascalbaljet Ready for review. Are the test:*:serve scripts needed for something? Seems like that server is only used by Playwright, which doesn't use these scripts anyway.

Just a shortcut to spin up the test server so we can easily tinker with it.

@pascalbaljet
Copy link
Member

I renamed the watch scripts to dev to be more consistent with Laravel. Also, consolidated the test:*:watch and test:*:serve scripts into test:*:dev.

@jrmajor
Copy link
Contributor Author

jrmajor commented Jun 17, 2025

I think that usually dev is used for “start dev server”, and watch is for “do a full build every time one of the files changes”, so it's more appropriate, but it's your call :)

@peaklabs-dev
Copy link

Why not use bun? It is faster and more modern.

@pascalbaljet
Copy link
Member

I've put some more work into this the last couple of days. I think this PR makes working on Inertia much easier:

  • Run pnpm dev to build the packages and watch for changes.
  • Run pnpm dev:test-app to boot up the test apps and watch for changes (all adapters). It now also watches server.js for changes and shows the full URL of the test app.
  • Run pnpm test:react to run the test suite.

Also, I've rewritten the contributing guide so it should be easier for people to get started.

@pascalbaljet
Copy link
Member

I checked the built assets and they're exactly the same before and after this PR. The only exception is the Svelte package, where the only change is the absence of an unused import.

@pascalbaljet pascalbaljet merged commit 90ec13c into inertiajs:master Jul 15, 2025
4 checks passed
@jrmajor jrmajor deleted the pnpm branch August 16, 2025 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants