Embetter @inertia decorator
#77
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
force-pushed
the
inertia-decorator-embetter
branch
from
3f3298a to
40b627d
Compare
BrandonShar
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
This makes sense, thanks @akx !
Only question I have for merging is do you think the change to checking for an HttpResponse is a breaking change? My guess is no, but are there are other reasonable non-dict responses?
|
@BrandonShar To the best of my knowledge, Django views always need to return a HttpResponse... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit descriptions :)