Concurrency check #431
Draft
Concurrency check #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the following logic: * in `enqueue_nd_range_kernel`, we catch all generated events for each queue. * those events get cleared when calling `queue.finish` or `cl.wait_for_events`. * if a kernel argument's queue's events are not in the current `wait_for`, we complain.
Uses WeakSet to store events so we don't have to worry when they get destroyed. The check for out of sync events is also more strict: we now store the event per (buffer, op) as well as per queue and only check events that are still valid in both and only for the current buffer.
# Conflicts: # pyopencl/invoker.py # test/test_wrapper.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved/continued from https://gitlab.tiker.net/inducer/pyopencl/-/merge_requests/93
cc @alexfikl