Skip to content

feat: add Skrining service classes for PCare integration - #8

Merged
indravscode merged 5 commits into
mainfrom
pcare
Aug 21, 2026
Merged

feat: add Skrining service classes for PCare integration#8
indravscode merged 5 commits into
mainfrom
pcare

Conversation

@indravscode

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI lite review requested due to automatic review settings August 21, 2026 06:20
@indravscode
indravscode merged commit 992a1d3 into main Aug 21, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the PCare integration by adding a new Skrining service class (and documenting its usage), while also introducing an update endpoint for Kunjungan and adjusting StatusPulang::rawatInap() to send boolean values as true/false strings in the URL.

Changes:

  • Added src/PCare/Skrining.php to support Skrining-related endpoints and added README usage examples.
  • Added update() to src/PCare/Kunjungan.php using a PUT request to kunjungan/v1.
  • Adjusted src/PCare/StatusPulang.php to encode the rawatInap status as 'true'/'false' instead of relying on PHP boolean string coercion.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/PCare/StatusPulang.php Converts boolean parameter into true/false string for URL path segment.
src/PCare/Skrining.php Introduces a new PCare service class for Skrining endpoints.
src/PCare/Kunjungan.php Adds a PUT-based update() method for kunjungan v1.
README.md Adds usage examples for the new Skrining service methods.
Suppressed comments (3)

src/PCare/Skrining.php:21

  • Typo in feature path: skrinning will generate incorrect PCare endpoint URLs. This should be skrining/peserta.
        $this->feature = "skrinning/peserta";

src/PCare/Skrining.php:27

  • Typo in feature path: skrinning will generate incorrect PCare endpoint URLs. This should be skrining/prolanis/dm.
        $this->feature = "skrinning/prolanis/dm";

src/PCare/Skrining.php:33

  • Typo in feature path: skrinning will generate incorrect PCare endpoint URLs. This should be skrining/prolanis/ht.
        $this->feature = "skrinning/prolanis/ht";

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/PCare/Skrining.php

public function rekap()
{
$this->feature = 'skrinning/rekap';
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants