Repository navigation
Conversation
…ection restartSession, killSession, focusSession, resizeSession, scroll and the focus refresh after OPEN_VIEW dropped their request promises with void. A request that races the terminal's exit or close comes back NOT_FOUND, and a dropped link rejects with YasDisconnectedError. Nothing handled either, so a Node embedder saw an unhandled rejection and exited.
|
Superseded by yas-run#101 (opened upstream). |
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several requests in
YasNativeWorkspaceConnectionare fire-and-forget:restartSession,killSession,focusSession,resizeSession, the scroll request, and the focus refresh afterOPEN_VIEW. They dropped the request promise withvoid. When one races its terminal's exit or close, the server answersNOT_FOUND; when the link drops, it rejects withYasDisconnectedError. Nothing handled either rejection, so a Node embedder hit an unhandled rejection and exited.Indent's computer client exits the process on unhandled rejections. Over 7d in prod,
observability.boot.unhandled_rejectionwithYasResultError: YAS request failed with status 3killedindent-computeron 15 sandboxes. Each crash restarts the client along with Chrome and background processes.settleTerminalRequestdrops those two expected failures andconsole.errors anything else, matching the existing.catch(console.error)pattern in this file.Verified with neo's
BlitShellrunning 20 concurrentbash.runcommands against the #49 server. Without this change, a stalesetFocus(focusSession←recomputeSnapshot←applyTerminalCatalog) produced an unhandledNOT_FOUNDabout once per 400 commands and crashed the process. With it: 1200/1200 OK and no unhandled rejections. Typecheck passes.No unit test: a vitest that leaves the rejection unhandled still passes under this config, so it can't pin the contract.
Pairs with #49; neo needs both in the same release.
Tag
@indentto continue the conversation here.