Repository navigation
Conversation
Coverage
|
indent
Bot
force-pushed
the
jsegaran/request-failure-listener
branch
from
September 30, 2026 19:05
69c2c29 to
39ab7ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
YasConnection.onRequestFailure(listener), so an embedder can observe every Request whose promise rejects in one place, without wrapping each family client call site.The listener receives
{ family, kind, error }and runs synchronously, before the rejection reaches the caller. It fires for:YasResultError)Non-OK statuses returned through
requestResultresolve as envelopes and are not reported.The hook goes on the pending request's
rejectrather than on a.catcharound the returned promise, so resolution timing does not change. Listener exceptions go through the existingreportListenerError.Indent's web client will use this to send YAS errors caused by our own code to Sentry. Consuming it in neo needs an
@yas-run/corerelease that includes this change.Tests:
vitest run src/__tests__/yas.test.tspasses, including the new case. The new case fails without the change.tsc --noEmitis clean.Tag
@indentto continue the conversation here.