Repository navigation
Conversation
`yas git show REV` sent a BLOB query for the commit and failed with Invalid. It now prints the commit in `git cat-file commit` layout (from the LOG record), and lists a directory for REV:DIR and REV:. --repo and `git discover PATH` were sent verbatim, so relative paths (including the default `.`) resolved against the server's cwd. They now resolve against the client's cwd, like fs and lsp --root.
This was referenced Sep 28, 2026
Coverage
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25. The diff shows only this change.
What was wrong
yas git show REValways sent a BLOB query, so asking for a commit failed with Invalid.--repoandyas git discover PATHwere sent as given, so relative paths, including the default., resolved against the server's cwd instead of the client's. From outside the server's cwd,yas git statusfailed with "request 0x0031/0x0000 failed with Invalid".Fix
show REVprints the commit ingit cat-file commitlayout, rebuilt from the LOG record.REV:DIRandREV:list the tree the way ls-tree does.REV:filestill prints the file's bytes.--repoand the discover path resolve against the client's cwd, the same as the fs and lsp--root. The help text for all 10 git--repoflags andlearn.mdare updated to match.Testing
commit_object_uses_cat_file_layoutandrelative_repository_paths_resolve_against_client_cwd.yas-clibin tests pass (147).Tag
@indentto continue the conversation here.