IWF-511: [iWF] Add a error field to the IwfEvent struct #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixydubs
reviewed
Feb 11, 2025
service/client/cadence/client.go
Outdated
| @@ -89,6 +89,12 @@ func (t *cadenceClient) GetApplicationErrorDetails(err error, detailsPtr interfa | |||
| return fmt.Errorf("not an application error. Critical code bug") | |||
| } | |||
|
|
|||
| func (t *cadenceClient) GetApplicationErrorTypeAndDetails(err error) (string, string) { | |||
| errType := t.GetApplicationErrorTypeIfIsApplicationError(err) | |||
| // TODO: Error Details will be added under IWF-511 | |||
There was a problem hiding this comment.
isn't this PR for IWF-511? when will the details be added?
There was a problem hiding this comment.
My bad 😄 That's not the correct number. Fixed now ✅
mixydubs
approved these changes
Feb 11, 2025
There was a problem hiding this comment.
This looks like a good way forward, but would defer to @lwolczynski for approval before merging
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #544 +/- ##
==========================================
+ Coverage 65.89% 66.08% +0.19%
==========================================
Files 62 62
Lines 6872 6927 +55
==========================================
+ Hits 4528 4578 +50
- Misses 2065 2070 +5
Partials 279 279 ☔ View full report in Codecov by Sentry. |
lwolczynski
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist