Repository navigation
style: adopt Python 3.10 Ruff conventions - #127
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The mechanical modernization is consistent with the Python 3.10 requirement and updated Ruff configuration.
Review effort: Balanced
Findings: None
What changed in this PR
Adopts Python 3.10 Ruff conventions across Awex without intended runtime behavior changes.
Changes:
- Enables previously ignored Ruff upgrade and
ziprules. - Modernizes annotations, abstract collection imports, and unbounded caches.
- Documents updated formatting and lint commands.
| File | Description |
|---|---|
pyproject.toml |
Enables Python upgrade and zip lint rules. |
CONTRIBUTING.md |
Documents Python 3.10 style and formatting commands. |
awex/writer/weights_writer.py |
Modernizes list annotations. |
awex/writer/nccl_writer.py |
Makes zip truncation explicit. |
awex/writer/astate_writer.py |
Modernizes list annotations. |
awex/vllm_awex_adapter.py |
Modernizes optional and dictionary annotations. |
awex/util/tensor_util.py |
Modernizes annotations and explicit zip behavior. |
awex/util/system_util.py |
Modernizes dictionary annotations. |
awex/util/device.py |
Uses collections.abc.Iterator. |
awex/util/cuda_ipc.py |
Uses collections.abc.Iterator. |
awex/util/common.py |
Modernizes list annotations. |
awex/transfer/transfer_plan.py |
Modernizes transfer-plan annotations. |
awex/transfer/nccl_comm.py |
Modernizes annotations and explicit zip behavior. |
awex/transfer/nccl_bounded_stream.py |
Makes packing zip behavior explicit. |
awex/transfer/mooncake_comm.py |
Modernizes annotations and zip usage. |
awex/tests/test_utils.py |
Modernizes tuple annotations. |
awex/tests/test_transfer_plan.py |
Modernizes tuple annotations. |
awex/tests/test_transfer_plan_cpu_sim.py |
Modernizes test annotations. |
awex/tests/test_tensor_utils.py |
Makes test zip behavior explicit. |
awex/tests/test_qwen3_vl.py |
Makes parameter comparison behavior explicit. |
awex/tests/test_nccl_bounded_stream.py |
Makes test zip behavior explicit. |
awex/tests/test_mooncake_transfer.py |
Makes fixture pairing behavior explicit. |
awex/tests/experimental/compare_megatron_vllm_weights_multi.py |
Modernizes script annotations. |
awex/tests/experimental/analyze_transfer_plan_dumps.py |
Modernizes imports and zip usage. |
awex/reader/weights_reader.py |
Modernizes reader annotations. |
awex/reader/nccl_reader.py |
Makes receive pairing behavior explicit. |
awex/reader/astate_reader.py |
Modernizes list annotations. |
awex/models/registry.py |
Modernizes registry annotations and imports. |
awex/models/qwen4_exp.py |
Uses functools.cache for unbounded caches. |
awex/models/qwen4_exp_layout.py |
Makes projection pairing behavior explicit. |
awex/models/qwen3_vl.py |
Modernizes converter annotations. |
awex/models/qwen3_moe.py |
Modernizes converter annotations. |
awex/models/qwen3_5.py |
Modernizes annotations and zip usage. |
awex/models/ling.py |
Modernizes converter annotations. |
awex/models/ling_linear.py |
Modernizes converter annotations. |
awex/meta/weight_meta.py |
Modernizes metadata annotations. |
awex/meta/train_meta_resolver.py |
Modernizes resolver annotations. |
awex/meta/meta_server.py |
Modernizes server annotations. |
awex/meta/meta_resolver.py |
Modernizes resolver interfaces. |
awex/meta/infer_meta_resolver.py |
Modernizes inference metadata annotations. |
awex/mbridge_loader.py |
Uses abstract collection imports. |
awex/engine/vllm.py |
Modernizes vLLM engine annotations. |
awex/engine/sglang.py |
Uses collections.abc.Callable. |
awex/engine/mcore.py |
Modernizes Megatron engine annotations. |
awex/engine/core.py |
Modernizes engine interfaces. |
awex/converter/sglang_converter.py |
Modernizes converter return annotations. |
awex/converter/mcore_converter.py |
Modernizes converter annotations and zip usage. |
awex/config.py |
Modernizes configuration annotations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Related issues
Does this PR introduce any user-facing change?