Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#2312 - Add support for new external recommender v2 #2313

Draft
wants to merge 77 commits into
base: main
Choose a base branch
from
Draft

#2312 - Add support for new external recommender v2 #2313

wants to merge 77 commits into from

Conversation

jcklie
Copy link
Contributor

@jcklie jcklie commented May 30, 2021 •
edited by reckart
Loading

What's in the PR

  • Move old external recommender to v1 subpackage
  • Can check connection to v2 recommender
  • Can select classifiers from the server
  • Predicting works
  • Training works

How to test manually

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@jcklie
#2312 - Add support for new external recommender v2
3dd2894 
- Move old external recommender to v1 subpackage
@jcklie jcklie added this to the 0.21.0 milestone May 30, 2021
@jcklie jcklie self-assigned this May 30, 2021
jcklie added 10 commits May 30, 2021 21:38
@jcklie
#2312 - Add support for new external recommender v2
e893679 
- Add a v2 copy of the v1 external recommender
@jcklie
#2312 - Add support for new external recommender v2
26738d1 
- Fix/Add autoconfig for external recommender
@jcklie
#2312 - Add support for new external recommender v2
5dfdef3 
- Fix/Add autoconfig for external recommender
@jcklie
#2312 - Add support for new external recommender v2
a8bc327 
- Can check connection
@jcklie
#2312 - Add support for new external recommender v2
b2f145c 
- Remove old documents
@jcklie
#2312 - Add support for new external recommender v2
fe09442 
- Can select classifiers from the server
@jcklie
#2312 - Add support for new external recommender v2
2f0085f 
- Move v1 tests to their own sub package
@jcklie
#2312 - Add support for new external recommender v2
dd9f8c8 
- Add FormatConverter
- Add data classes
- Started tests
@jcklie
#2312 - Add support for new external recommender v2
3a0d2cd 
- Start predicting
@jcklie
#2312 - Add support for new external recommender v2
31ee5fa 
- Predicting works
@reckart reckart marked this pull request as draft June 5, 2021 22:31
jcklie and others added 13 commits June 13, 2021 18:31
@jcklie
Merge branch 'master' into feature/2312-external-recommender-v2
d611fc8
@jcklie
#2312 - Add support for new external recommender v2
eebc383 
Use exceptions in external recommender API
@jcklie
#2312 - Add support for new external recommender v2
ba49d5a 
Use exceptions in external recommender API
@jcklie
#2312 - Add support for new external recommender v2
e741152 
WIP: Add more API methods
@jcklie
Merge branch 'master' into feature/2312-external-recommender-v2
0684d17
@jcklie
#2312 - Add support for new external recommender v2
6863195 
- Add more API implementations
- Add more tests
@jcklie
#2312 - Add support for new external recommender v2
99bc6a8 
- Start implementing training
@jcklie
#2312 - Add support for new external recommender v2
a605e94 
- Add tests for two more API endpoints
- Improved error messages
@jcklie
#2312 - Add support for new external recommender v2
b0754cb 
- Use simpler for classifier/model ids
- Add status code check for listDocumentsInDataset
@reckart
Merge branch 'master' into feature/2312-external-recommender-v2
043b89c
@reckart
Merge branch 'master' into feature/2312-external-recommender-v2
48667c1
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
c2137cf 
* main: (80 commits)
  #2505 - Slot features should be ignored when comparing annotations for the purpose of bulk-annotation
  #2505 - Slot features should be ignored when comparing annotations for the purpose of bulk-annotation
  #2286 - Upgrade dependencies
  #2491 - Bulk-deletion does not unselect annotation
  #2543 Show export progress only on export
  #2541 Cannot export project when curation started
  #2534 Add word conversion colab notebook
  No issue. Fix scope of the tocify dependencies.
  No issue. Fix layout on external search page.
  #2522 - Opening sidebar changes document
  No issue. Avoid error when switching from main to 20.x branch.
  #2176 - Make long relations nicer without arcs II
  Bump elasticsearch from 6.8.15 to 6.8.17 in /inception
  #2534 Add word conversion colab notebook
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-20.1
  #2523 - Reset filter on dynamic workload page
  #2176 - Make long relations nicer without arcs II
  #2522 - Opening sidebar changes document
  #2426 - Difference in labelling of annotation marker vs identifier lookup
  ...
@jcklie
Merge branch 'main' into feature/2312-external-recommender-v2
66cb386
@reckart reckart removed this from the 21.0 milestone Sep 1, 2021
@reckart reckart mentioned this pull request Mar 30, 2023
Closed
@reckart reckart modified the milestones: 28.0, 29.0 May 2, 2023
@reckart reckart modified the milestones: 29.0, 30.0 Jul 7, 2023
@reckart reckart modified the milestones: 30.0, 31.0 Sep 19, 2023
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
527ac03 
* main: (94 commits)
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  #4240 - Facilitate using DIAM serializer in isolation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.5
  #4230 - Upgrade dependencies
  #4230 - Upgrade dependencies
  #4235 - Direct access-by-URL to sidebar curation mode sometimes does not work
  #4229 - Better project template selection
  #4229 - Better project template selection
  #4232 - Drop evaluation page
  #4229 - Better project template selection
  #4230 - Upgrade dependencies
  #4229 - Better project template selection
  No issue: Update system requirements and improve pointers to Docker-based deployment
  No issue: Call out to admins to look at the admin guide when reaching the installation section in the users guide.
  #4215 - Ability to specify GID and UID for the user used inside the Docker image
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-29.4
  #4226 - Display logout button on annotation page if dashboard access is disabled
  ...

% Conflicts:
%	inception/inception-imls-external/pom.xml
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
d8b115f 
* main: (68 commits)
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4316 - Dissolve generic API module
  #4314 - Move project API to own module
  #4308 - Support for custom XML formats
  #4308 - Support for custom XML formats
  #4308 - Support for custom XML formats
  #4310 - Viewport tracking does not work well in RecogitoJS editor
  #4308 - Support for custom XML formats
  #4302 - Files imported as HTML do not show properly in HTML-based editor
  #4305 - New predictions message is shown even if no new predictions were generated
  #4304 - Log more startup messages through boot logger
  #4229 - Better project template selection
  #4298 - Recommender status says "Waiting for evaluation" for recommenders that cannot be evaluated
  #4297 - Popover always showing "tag not in tagset" even if feature has no tagset at all
  #4294 - Infer paragraph boundaries when displaying plain text files in HTML-based editors
  #4150 - Upgrade dependencies
  ...
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
9f23436
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
ea684f7
@reckart reckart modified the milestones: 31.0, 32.0 Jan 6, 2024
@reckart reckart modified the milestones: 32.0, 33.0 Mar 9, 2024
@reckart reckart modified the milestones: 33.0, 34.0 Jun 2, 2024
@reckart reckart modified the milestones: 34.0, 35.0 Jul 27, 2024
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
208dc92 
* main: (359 commits)
  #5047 - Clean up layer detail UI a bit
  #4949 - Showing the start and end points of relations in left side bar
  No issue: Minor cleaning up
  #5043 - Ability to specify token breaking zones when calling tokenizer
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-6
  #5009 - Better handling of stacked annotations with link features in curation
  #5009 - Better handling of stacked annotations with link features in curation
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0-beta-6
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.6
  #5040 - Improve feature form tab navigation
  #5037 - Show fraction of annotators that chose a certain label in curation sidebar mode
  #5035 - NBSPs should not be treated as tokens
  #5031 - ChatGPT recommender fails because format is not a supported parameter
  #5029 - Duplicate lines on the about page
  #5027 - Add more CSP configurations
  #4753 - Entity linker should skip already linked concepts
  #5007 - Lazy details on suggestions for multi-value concept features fail rendering
  ...
@reckart
Merge branch 'main' into feature/2312-external-recommender-v2
168fd5e 
* main: (30 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0
  No issue: Mention MS SQL and PosgreSQL as experimental DB options
  No issue: Fix versions after merge
  #5043 - Ability to specify token breaking zones when calling tokenizer
  #5064 - Project template for PHI annotation
  #5071 - Better document which layers are supported by which formats
  #5061 - Multiple synchronous recommenders only the last one wins
  #5064 - Project template for PHI annotation
  #5068 - Show annotation sidebar by default
  #5033 - Ability to configure recommenders interactively on the annotation page
  #5066 - Increase default number of rows for brat editors
  #5056 - Ability to configure additional languages for knowledge bases
  #4909 - Upgrade dependencies
  #5056 - Ability to configure additional languages for knowledge bases
  #4909 - Upgrade dependencies
  No issue: Actually, document-metadata doesn't seem to be experimental after all...
  No issue: Set version to 35.0-SNAPSHOT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.7
  ...
@reckart reckart modified the milestones: 35.0, 36.0 Jan 7, 2025
@reckart reckart modified the milestones: 36.0, 37.0 Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jcklie jcklie

Labels
⭐️ Enhancement New feature or request Module: Recommender
Projects
None yet
Milestone
37.0
Development

Successfully merging this pull request may close these issues.
2 participants
@jcklie @reckart