Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add simplified MyObservations for logged out users with at least 1 obs #2599

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

kueda
Copy link
Member

@kueda kueda commented Jan 8, 2025

Reviewer notes:

  • Only works in debug mode
  • Adding obs is in debug mode is current broken pending completion of the new confirmation screen, so to test this PR, you need to add at least one obs while signed out in the default mode, then enter debug mode
  • I tried to avoid polluting MyObservations with experimental code, so there's some degree of awkward duplication
  • MyObservationsSimple is intentionally monolithic; IMO we can clean and modularize stuff like calculating leaf taxa from the Realm db when we're closer to releasing this; happy to field critiques of style and organization, but I'm mostly interested in whether this meets the product requirements

Closes #MOB-317

@kueda kueda force-pushed the mob-317-simplified-myobservations-mode-for-logged-out-users-with-1 branch from 41859f4 to 6011e68 Compare January 8, 2025 23:31
@kueda kueda marked this pull request as ready for review January 9, 2025 00:40
@kueda kueda requested a review from kvangork January 9, 2025 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant