improvements to the first steps module#5
Open
glasswalk3r wants to merge 6 commits intoin4it:masterfrom
Open
Conversation
The previous resource is considered deprecated by newer versions of the Azure provider, all changes were adaptation to use this newer resource.
- Using the http module to retrieve the current public IP to use as part of the security group - Also upgraded the Azure provider version - Also fix minor bug during removal of all resources, due the lack of association between a security group and the network interface.
Also updated the doc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
httpmodule to retrieve the current public IP to use as partof the security group
association between a security group and the network interface.