Skip to content

Fix LoadShader bug. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix LoadShader bug. #3

wants to merge 1 commit into from

Conversation

zjingcong
Copy link

Fix a typo in LoadShader function, which will cause loading vert shader as frag shader.

imtumbleweed
imtumbleweed reviewed Sep 18, 2018
View reviewed changes
Copy link
Owner

@imtumbleweed imtumbleweed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bug. The shader pair is intentionally loaded progressively, first vertex shader, then nested within it is the fragment shader. Each request is for a separate file, this is accurate.

@zjingcong
Copy link
Author

But in the code, it sends request for filename_vs for two times.

@imtumbleweed
Copy link
Owner

Hmmm. I'll check. @zjingcong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@imtumbleweed imtumbleweed imtumbleweed left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zjingcong @imtumbleweed