feat: duplicate and delete templates, add toggle for raw issuance #242

coplat · 2025-12-01T14:19:29Z

Description of change

Adds a toggle for raw issuance, overriding the need to use a template and allowing manual json input. This can be toggled through the config under the skip_template_enforcement bool which defaults to false.

Further, the commands and corresponding endpoints for DuplicateTemplate and DeleteTemplate have also been added, allowing duplication of existing templates which results in a template with a new ID and the word "Copy" appended to the end of the template's title.

To duplicate a template you can now make a POST request to v0/templates/duplicate-template with the body:

{
    "sourceTemplateId": "example-template-id-123"
}

To delete a template you can simply make a POST request to `v0/template/delete-template with the body:

{
    "templateId": "example-template-id-123"
}

Additionally, the previous PATCH request has been now replaced by a POST request to v0/templates/update-template to update elements of a template.

Our postman collection and OpenAPI documentation have been updated accordingly.

Links to any relevant issues

Addresses parts of Issue #202

How the change has been tested

Describe the tests that you ran to verify your changes.
All existing tests pass. Functionality has also been tested through the postman collection.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

I have followed the contribution guidelines for this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
I have successfully tested this change in a docker environment

…st body

…argo.toml`

…ple `Cargo.toml` files

…sistency

…onfig`

nanderstabel · 2025-12-04T15:58:36Z

agent_library/src/template/command.rs

+    DuplicateTemplate {
+        duplicate_from: String,
+        new_template_id: String,
+    },


This one we don't really need anymore right since you now added duplicate_from to CreateTemplate?

I think we could also do it the other way: not introduce duplicate_from to CreateTemplate and have a separate DuplicateTemplate command, which implicitly just copies all fields. Otherwise, you'd have to supply all other fields as well when calling CreateTemplate (same display, same credential_format, etc.).

I think that what you suggest would indeed be the right DDD way of doing this but atm technically that would be still a bit tricky to do. When the Template::handle function receives the command:

DuplicateTemplate { duplicate_from: String, new_template_id: String, }

then it has no way of accessing the field data from duplicate_from. What we would need then is define a LibraryService that acts as a Domain Service. This Domain Service then should contain access to the LibraryState and it should have a method that simply accepts a Template ID, and returns the TemplateView which can be used in the Template::handle function to do the duplication. However, the problem here is that if we want to do this this will require some refactor related to agent_store (which I have started btw but not completed yet).

But once we have that then I think it's a good to idea to implement the LibraryService so what we can do what you suggested. So, TODO comment for now? 😅

I agree that this would be a bit tricky for the moment. I added a TODO for now.

nanderstabel · 2025-12-04T15:59:06Z

agent_library/src/template/event.rs

+    },
+    TemplateDuplicated {
+        duplicate_from: String,
+        new_template_id: String,


Similar to https://github.com/impierce/ssi-agent/pull/242/files#r2589651162, we don't need this one right?

See reply https://github.com/impierce/ssi-agent/pull/242/files#r2591738067

nanderstabel · 2025-12-04T16:02:00Z

agent_library/src/template/views/mod.rs

                self.modified_at.replace(modified_at.clone());
            }
+            TemplateDeleted { template_id: _ } => {
+                self.status = Status::Deleted;


Similar to the code you added to the apply function for this Event in aggregate.rs:

*self = Self::default(); self.template_id = template_id; self.status = Status::Deleted;

Here all the values should also be 'wiped'.

nanderstabel · 2025-12-04T16:05:04Z

agent_api_rest/src/library/templates/mod.rs

 #[derive(Deserialize, Serialize, Default)]
 #[serde(default, rename_all = "camelCase")]
 pub struct PostTemplatesEndpointRequest {
+    pub id: Option<String>,


Since you branched off from my previous PR before it got merged I removed the id field from this request struct so you can also remove it again.

nanderstabel · 2025-12-04T16:19:57Z

agent_api_rest/src/library/templates/mod.rs

+        // Fetch original template data.
+        let original_template = query_handler(&old_template_id, &state.query.template)
+            .await?
+            .ok_or_else(|| ApiError::new(StatusCode::NOT_FOUND))?;


Returning a 404 NOT FOUND status code would communicate to the client that the endpoint itself does not exist, which is not true. I think it is better to use 422 Unprocessable Content here and include a Problem Details. You can follow this example in credentials.rs (which also uses NOT_FOUND which is wrong so please add a TODO comment there 😅 ):

ApiError::builder(StatusCode::NOT_FOUND) .title("No Credential Configuration Found") .type_url(type_url("issuance#no-credential-configuration-found")) .message(format!( "No Credential Configuration found with id: `{credential_configuration_id}`" )) .finish()

What this means as well is that you will need to add the description of the error as well to the docs folder. You will need to add a library.md file and include the description (you can take a look at the Problem Details descriptions we already have in the other .md files for inspiration).

nanderstabel · 2025-12-04T16:21:42Z

agent_api_rest/src/library/templates/mod.rs

+            display: original_template.display.clone(),
+            credential_format: original_template.credential_format.clone(),
+            creator: original_template.creator.clone(),
+            holder_type: original_template.holder_type.clone(),
+            tags: original_template.tags.clone(),
+            status: Status::Draft,
+            visibility: original_template.visibility.clone(),
+            description: original_template.description.clone(),
+            r#type: original_template.r#type.clone(),
+            schema: original_template.schema.clone(),


If I am not mistaken you can remove all the .clone() occurrences here.

nanderstabel · 2025-12-04T17:17:50Z

agent_api_http/postman/ssi-agent.postman_collection.json

+											"    pm.collectionVariables.set(\"template_id\", response.id);",
+											"    console.log(\"Saved template_id: \" + response.id);",


Here as well as in the Request Body for "Duplicate Template" you use template_id but for the other endpoints we use TEMPLATE_ID. Is that deliberate or can we use TEMPLATE_ID for everything?

nanderstabel · 2025-12-04T17:21:28Z

agent_api_http/postman/ssi-agent.postman_collection.json

+		{
+			"key": "template_id",
+			"value": ""


Can we re-use TEMPLATE_ID instead of adding this one?

daniel-mader · 2025-12-05T07:47:23Z

agent_api_rest/src/library/templates/mod.rs

+
+        let create_command = TemplateCommand::CreateTemplate {
+            template_id: new_template_id.clone(),
+            duplicate_from: Some(old_template_id),


Although I called it duplicate_from in issue #202, I think that name it isn't fitting too well (apart from that it's grammatically wrong as well -- should be "duplicate of").

When you duplicate a template, then adapt it and change it quite a bit over time, something such as original_template is probably more fitting. This implies a duplicate, but more elegantly.

daniel-mader · 2025-12-05T07:50:30Z

agent_library/src/template/aggregate.rs

 pub struct Template {
    #[serde(rename = "id")]
    pub template_id: String,
+    pub duplicate_from: Option<String>,


See comment https://github.com/impierce/ssi-agent/pull/242/files#r2591724162

…sed Duplicate command and event.

…funtion

nanderstabel and others added 14 commits October 28, 2025 15:12

feat: initialize agent_catalogue module

a21d43e

fix: add missing events to HTTP event publisher

de16778

style: move agent_catalogue workspace member to new line

cf21390

refactor: rename agent_catalogue to agent_catalog

bc3b9e5

style: fix formatting of filter closure in get_templates function

8a9f39f

feat: add template and all_templates tables to init.sql

f34aa65

feat: replace agent_catalog with agent_library

bd98333

feat: enhance template management with update commands

8822eca

feat: add update template endpoint with PATCH method and sample reque…

c17737e

…st body

fix: remove unnecessary features from agent_shared dependency in `C…

475dd41

…argo.toml`

Merge branch 'beta' into feat/init-agent-catalogue

dc7813a

fix: replace async-std dependency with workspace reference in multi…

be44b77

…ple `Cargo.toml` files

fix: reorder agent_library dependency in Cargo.toml files for con…

8baea7b

…sistency

feat: add toggle for raw issuance

d61c9c1

Base automatically changed from feat/init-agent-catalogue to beta December 1, 2025 16:00

coplat and others added 6 commits December 2, 2025 09:06

Merge branch 'beta' into feat/raw-issuance-toggle

4f5b4eb

refactor: config toggle

9eedf06

feat: delete_template and duplicate_template functionality

02c2cb6

refactor: test `provisioned_config_successfully_merged_into_default_c…

3fd136a

…onfig`

fix: filter deleted templates in get_templates

04676f4

feat: add duplicate_from to Template aggregate

0de6d44

coplat changed the title ~~feat: add toggle for raw issuance~~ feat: duplicate and delete templates, add toggle for raw issuance Dec 3, 2025

coplat added 3 commits December 4, 2025 14:34

refactor: Box schema field

5022112

feat: update Postman collection for template duplication and deletion

6d6c6e1

nit: add comments

986113c

coplat marked this pull request as ready for review December 4, 2025 15:32

coplat requested review from daniel-mader and nanderstabel as code owners December 4, 2025 15:32

nanderstabel requested changes Dec 4, 2025

View reviewed changes

nanderstabel reviewed Dec 4, 2025

View reviewed changes

daniel-mader reviewed Dec 5, 2025

View reviewed changes

coplat self-assigned this Dec 5, 2025

coplat added 2 commits December 5, 2025 17:28

refactor: rename duplicate_from to source_template_id, remove unu…

de4285b

…sed Duplicate command and event.

refactor: Postman collection and error handling

10db6c6

nanderstabel mentioned this pull request Dec 11, 2025

feat: initialize IssuerMetadataSynchronizationPolicy #244

Merged

7 tasks

coplat and others added 7 commits December 19, 2025 13:26

merge beta into feat/raw-issuance-toggle

31b3f61

chore: separate duplicate_template function from create_template …

c1a1e5e

…funtion

chore: update postman collection for new api endpoints

97b1e69

Merge branch 'beta' into feat/raw-issuance-toggle

4be9ff7

chore: update postman

803d31f

docs: openapi

a7ae052

nit: needless_return

5936e25

		" pm.collectionVariables.set(\"template_id\", response.id);",
		" console.log(\"Saved template_id: \" + response.id);",

feat: duplicate and delete templates, add toggle for raw issuance #242

Are you sure you want to change the base?

feat: duplicate and delete templates, add toggle for raw issuance #242

Conversation

coplat commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of change

Links to any relevant issues

How the change has been tested

Definition of Done checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nanderstabel Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

daniel-mader Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

coplat commented Dec 1, 2025 •

edited

Loading

nanderstabel Dec 4, 2025 •

edited

Loading

daniel-mader Dec 5, 2025 •

edited

Loading