Skip to content

Conversation

@nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented Nov 4, 2025

Description of change

This PR updates the credential issuance flow to correctly handle an optional iss (issuer) claim in the Proof contained in the Credential Request, aligning with the OpenID4VCI specification.

Links to any relevant issues

How the change has been tested

  • Manually tested against UniMe
  • Added the with_anonymous_access test case to the test_credential_endpoint test.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
..._rest/src/issuance/credential_issuer/credential.rs 97.33% <100.00%> (ø)
agent_event_publisher_http/src/lib.rs 73.91% <100.00%> (ø)
agent_issuance/src/credential/aggregate.rs 89.19% <100.00%> (+0.03%) ⬆️
agent_issuance/src/offer/aggregate.rs 81.89% <100.00%> (-0.39%) ⬇️
agent_issuance/src/offer/event.rs 50.00% <ø> (ø)
agent_issuance/src/offer/views/mod.rs 88.88% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nanderstabel nanderstabel self-assigned this Nov 5, 2025
@nanderstabel nanderstabel added the Added A new feature that requires a minor release. label Nov 5, 2025
@nanderstabel nanderstabel changed the title fix: change make iss in Proof optional feat: support optional iss claim for anonymous credential issuance Nov 5, 2025
@nanderstabel nanderstabel marked this pull request as ready for review November 5, 2025 15:29
@nanderstabel nanderstabel changed the title feat: support optional iss claim for anonymous credential issuance fix: support optional iss claim for anonymous credential issuance Nov 10, 2025
@nanderstabel nanderstabel merged commit 65df5dd into beta Nov 27, 2025
10 of 11 checks passed
@nanderstabel nanderstabel deleted the fix/anonymous-access branch November 27, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Added A new feature that requires a minor release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants