fix: "verified up to" bar no longer gets stuck (no refactor)#336
Open
GitLuckier wants to merge 2 commits intomappingfrom
Open
fix: "verified up to" bar no longer gets stuck (no refactor)#336GitLuckier wants to merge 2 commits intomappingfrom
GitLuckier wants to merge 2 commits intomappingfrom
Conversation
pimotte
requested changes
Apr 9, 2026
Contributor
pimotte
left a comment
pimotte
left a comment
There was a problem hiding this comment.
Yeah, I think that's actually what we really want! The logic in the listener is not too fancy, but clearly we can have bugs here, so I think it makes sense to extract the entire listener to a separate file and unit test them, in this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the bug where the progress bar would get stuck, even if lean was done checking. This time a minimal fix without the refactoring.
Instead of the refactoring I did earlier, I could instead extract this message handling into its own file and write tests for it. Let me know if that is something we want or just leave it as is for now.