Conversation
|
Insertion of math and text nodes still break the document and don't update the line numbers. Is this acceptable for re-enabling the menubuttons? The fix for making sure that the text and math node insertions don't break the document is to include a check in |
|
@DikieDick Thanks! I'm pretty sure I have fixed the issues. I'm not particularly happy about passing the (serialized) doc into node update, but I'm not sure if we have an architecturally better way that doesn't make the mapping more complicated. |
|
I added logic to count the actual newlines that are deleted when deleting nodes from the document. Furthermore:
|
|
Superseded by #87 I'll leave this open for review convenience for now. |
Fixes the line numbers and parent selection from #71
Reenables the buttons as well.
To test: