Open
Conversation
pimotte
approved these changes
Nov 27, 2025
Contributor
pimotte
left a comment
There was a problem hiding this comment.
LGTM. (One suggestion for a comment).
Do note that this breaks some exercise sheets, but that's also the point. I don't think we want to try updating coq-waterproof mid-course for this, so maybe we should keep the adapted sheets in a branch.
I think going directly to absolute values should depend on the didactics. If you teach with the general definition in the metric space, I think it makes sense to add an alternative characterization that goes straight to absolute values.
With respect to normalization: I think this makes sense, but it's something I would put on low prio: It's a lot of work and I'm not sure it will have a large impact.
| @@ -62,7 +62,7 @@ Definition cv_implies_cv_abs_to_l_abs := cv_cvabs. | |||
|
|
|||
| Notation "| x |" := (Rabs x) (at level 20, format "| x |") : R_scope. | |||
Contributor
There was a problem hiding this comment.
Suggested change
| Notation "| x |" := (Rabs x) (at level 20, format "| x |") : R_scope. | |
| (* The symbol below is the standard pipe, unicode codepoint: U+007C *) | |
| Notation "| x |" := (Rabs x) (at level 20, format "| x |") : R_scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some things to think about: