skip loacl variable in dhcp_netid_free when reload dnsmasq config #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a proper place to put PRs to dnsmasq, it's just a mirror. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test on version 2.86,
# ps aux | grep dns nobody 117520 0.0 0.0 6796 864 ? S 18:34 0:00 /usr/local/zstack/dnsmasq --conf-file=/var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/dnsmasq.conf -K# cat /var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/dnsmasq.conf domain-needed bogus-priv no-hosts addn-hosts=/var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/hosts.dns dhcp-option=vendor:MSFT,2,1i dhcp-lease-max=65535 dhcp-hostsfile=/var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/hosts.dhcp dhcp-optsfile=/var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/hosts.option log-facility=/var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/dnsmasq.log interface=inner1 except-interface=lo bind-interfaces leasefile-ro dhcp-range=172.24.0.1,static`# cat /var/lib/zstack/dnsmasq/br_eth0_20accb7db1af4070b31ae6b18af15d57/hosts.dhcp
fa:32:c4:95:ae:00,set:fa32c495ae00,172.24.24.10,172-24-24-10,infinite
fa:43:23:f9:c1:00,set:fa4323f9c100,172.24.24.13,172-24-24-13,infinite
reboot vm 172.24.24.13, then kill -1 $dnsmasq， dnsmasq will segfault.