[EXPERIMENTAL] [DO NOT MERGE] chore: ID-3927: ERC 7579 compliance #68
Conversation
naveen-imtb
changed the title
| } | ||
|
|
||
| function _removeModule(uint256 moduleTypeId, address module) internal { | ||
| address[] storage modules = _moduleList[moduleTypeId]; |
There was a problem hiding this comment.
I'd explore storing the modules in a linked list for example SentinelList (audited) or enumerablemap.
if _moduleList becomes big, the for loop'ed sloads could get expensive on gas
| ERC-7579 CORE | ||
| //////////////////////////////////////////////////////////////////////////*/ | ||
|
|
||
| function execute(bytes32 mode, bytes calldata executionCalldata) external override { |
There was a problem hiding this comment.
this function is usually reserver for self calls or 4337 EPs. Or by something like ERC-7821
7579 Executors will always use executeFromExecutor
| bytes calldata data | ||
| ) external returns (bool success, bytes memory returnData) { | ||
| // Only allow the account itself to execute transactions | ||
| require(msg.sender == address(this), "ImmutableExecutor: UNAUTHORIZED"); |
There was a problem hiding this comment.
be careful here for potential reentrancy. if someone manages to coerce the ImmutableExecutor to call it's own onInstall function. it might be possible to chain things together and get arbitrary execution on target
| function decodeBatch(bytes calldata executionCalldata) | ||
| internal | ||
| pure | ||
| returns (Execution[] memory executions) |
There was a problem hiding this comment.
solady's ERC7579Lib has nice decode helper function here that give you calldata pointers for the Execution[]. saves some malloc gas
| * @param executionCalldata The encoded execution calldata | ||
| * @return executions Array of decoded delegate executions | ||
| */ | ||
| function decodeDelegateCallBatch(bytes calldata executionCalldata) |
There was a problem hiding this comment.
usually ERC7579 accounts don't implement this. cause you can just delegatecall a multicall that implements batch delegatecall and get the same behavior. reduces code complexity in the account
2 participants
No description provided.