fix(ci): build audience-core before SDK bundle in CDN deploy workflow (AUD-239)#2867
Merged
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit 67f5535
☁️ Nx Cloud last updated this comment at |
… (AUD-239) The deploy workflow was calling pnpm --filter @imtbl/audience build without first building its local workspace dependency @imtbl/audience-core, causing esbuild to fail with "Could not resolve @imtbl/audience-core" because the dist/ folder did not exist in CI. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
✅ Audience Bundle Size — @imtbl/audience
Budget: 24.00 KB gzipped (warn at 20.00 KB) |
nattb8
force-pushed
the
fix/audience-cdn-deploy-missing-core-build
branch
from
67f5535 to
dd2565b
Compare
ImmutableJeffrey
previously approved these changes
Apr 29, 2026
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
… (AUD-239) @imtbl/metrics is a workspace dep of audience-core and is inlined by the SDK bundle build via BUNDLED_WORKSPACE_DEPS. Without its dist/ present in CI the bundle build would still fail. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1e58c6b. Configure here.
Replace three manual build steps with a single `pnpm --filter @imtbl/audience... build` which automatically builds all transitive workspace dependencies in the correct order, matching the pattern already used in audience-bundle-size.yaml. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ImmutableJeffrey
approved these changes
Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
deploy-audience-cdn.yamlworkflow was failing on every triggered run because it built@imtbl/audiencewithout first building its local workspace dependency@imtbl/audience-coredist/folder, so esbuild could not resolve@imtbl/audience-coreimportspnpm --filter @imtbl/audience-core buildstep immediately before the SDK bundle buildhttps://linear.app/imtbl/issue/SDK-265/fixci-cdn-deploy-workflow-fails-missing-audience-core-build-step
Broken since: #2863
Test plan
🤖 Generated with Claude Code
Note
Low Risk
Single-line CI workflow change that only affects build scoping for the CDN deploy job; low risk aside from potentially longer build time or unexpected dependency build interactions.
Overview
The CDN deploy workflow now runs
pnpm --filter @imtbl/audience... buildinstead of building only@imtbl/audience, ensuring its local workspace dependencies (e.g.,audience-core) are built as part of the bundle step so the CI build can resolve imports before uploading to S3.Reviewed by Cursor Bugbot for commit 3727331. Bugbot is set up for automated code reviews on this repo. Configure here.