feat(passport): ID-3934: Render the headless login / embedded login prompt #2705
+1,066
−116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View your CI Pipeline Execution ↗ for commit f54a728
☁️ Nx Cloud last updated this comment at |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
haydenfowler
force-pushed
the
feature/ID-3934-render-embedded-login
branch
from
8d38b51 to
689c0d7
Compare
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on October 13. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
ImmutableJeffrey
previously approved these changes
Sep 18, 2025
ImmutableJeffrey
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi👋, please ensure the PR title follows the below standards:
Summary
This PR adds support to render the headless login prompt by default when the
loginmethod is called.Detail and impact of the change
Changed
Added
disableHeadlessLoginPromptOverlayproperty to thepopupOverlayOptionsconstructor parameter to allow consumers to disable rendering the initial login page within an iFrame.